Skip to content

JS: Restrict Expr.getDocumentation #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
semmle-qlci merged 4 commits into from
Jul 23, 2019
Merged

JS: Restrict Expr.getDocumentation #1617

semmle-qlci merged 4 commits into from
Jul 23, 2019

Conversation

@asger-semmle
Copy link
Contributor

@asger-semmle asger-semmle commented Jul 22, 2019

Restricts Expr.getDocumentation to not have results in as many cases.

Prevously, every element of an array literal would be seen as having the same documentation as the surrounding statement:

/** @type {Foo} */
let xs = [ 1, 2, 3 ];

Evaluation of the readability-all suite.

@asger-semmle asger-semmle requested a review from a team as a code owner July 22, 2019 16:34
xiemaisi
xiemaisi approved these changes Jul 23, 2019
View reviewed changes
Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sensible.

@semmle-qlci semmle-qlci merged commit 8b60314 into github:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xiemaisi xiemaisi xiemaisi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

JS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asger-semmle @xiemaisi @semmle-qlci